Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile fixed for M1 Macs #2364

Closed
wants to merge 0 commits into from
Closed

Conversation

k0taperk0t
Copy link
Contributor

@k0taperk0t k0taperk0t commented Sep 29, 2023

Change Overview

Attempt to run make golint or make build, as described here, on Mac with M1 chip causes the error:

% make golint
running CMD in the containerized build environment
Unable to find image 'ghcr.io/kanisterio/build:v0.0.24' locally
v0.0.24: Pulling from kanisterio/build
docker: no matching manifest for linux/arm64/v8 in the manifest list entries.
See 'docker run --help'.
make[1]: *** [run] Error 125
make: *** [golint] Error 2

This PR fixes that error.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@k0taperk0t
Copy link
Contributor Author

I agree to the DCO for all the commits in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant