Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable importas golang linter #2239

Merged
merged 31 commits into from
Dec 21, 2023
Merged

Enable importas golang linter #2239

merged 31 commits into from
Dec 21, 2023

Conversation

ankitjain235
Copy link
Contributor

@ankitjain235 ankitjain235 commented Aug 3, 2023 •
edited
Loading

Change Overview

This PR enables importas Golang linter.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@ankitjain235 ankitjain235 marked this pull request as ready for review August 3, 2023 15:28
@ankitjain235 ankitjain235 changed the title Enable importas linter Enable go linter - PR#3 Aug 3, 2023
@ankitjain235 ankitjain235 mentioned this pull request Aug 7, 2023
Closed
@ankitjain235 ankitjain235 changed the title Enable go linter - PR#3 Enable importas golang linter Dec 1, 2023
@pavannd1 pavannd1 requested a review from hairyhum December 1, 2023 17:54
pavannd1
pavannd1 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a newline. LG otherwise

.golangci.yml Outdated Show resolved Hide resolved
@pavannd1 pavannd1 added the kueue label Dec 8, 2023
@ankitjain235 ankitjain235 removed the kueue label Dec 8, 2023
@ankitjain235
Copy link
Contributor Author

@pavannd1 There PR is on top of #2238 so we'll need to merge that one before. Removed kueue for now.

Base automatically changed from enable-linters-2 to master December 20, 2023 09:19
@mergify mergify bot merged commit e55fc37 into master Dec 21, 2023
14 checks passed
@mergify mergify bot deleted the enable-linters-3 branch December 21, 2023 04:17
@ankitjain235 ankitjain235 linked an issue Dec 21, 2023 that may be closed by this pull request
Add more linters to golangci.yaml #2173
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@hairyhum hairyhum hairyhum approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more linters to golangci.yaml
3 participants
@ankitjain235 @hairyhum @pavannd1