chore(infra): cleanup triage workflows #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
force-pushed
the
fix/triage-workflow
branch
from
5428535 to
7b7c232
Compare
julio-lopez
force-pushed
the
fix/triage-workflow
branch
from
7b7c232 to
e807df4
Compare
- Prevent funning the triage PR workflow for dependabot submitted PRs. This is failing because the required credential is not available for that workflow on dependabot submitted PRs. - Add names to jobs.
julio-lopez
force-pushed
the
fix/triage-workflow
branch
from
e807df4 to
c53141c
Compare
julio-lopez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Split the
triage.ymlworkflow into 2 separate ones, one for PRs and another one for issues, since these jobs execute on different triggered events (pull_request&issues). This also simplifies the conditions in the jobs and the steps, since it is no longer necessary to check for the type of event that triggered the workflow.It also prevents running the triage PR workflow for PRs submitted by
dependabot.This is failing because the required credential is not available for PRs submitted by
dependabot.Allow running the "comment" step on PRs submitted from forks, and avoid adding a rather useless comment on PRs opened from the same repo.
Other minor cleanups.
Pull request type
Test Plan
⚡ CI: GHA run
No automatically added comment should be added in this PR. In order to re-run the workflow it is necessary to close and re-open the PR :(
The PR should be triaged nonetheless and added to the appropriate column in the project.
The triage issues workflow can only be tested after merging this PR into the main branch (AFAICT).
See sample run of the
triage-pr.yamlworkflow at #2336 (https://github.com/kanisterio/kanister/actions/runs/6192490531/job/16812642576)