-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validating Webhook should accept TLS cert in K8s Secret #1515
Comments
Thanks for opening this issue 👍. The team will review it shortly. If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md. If you haven't already, please take a moment to review our project's Code of Conduct document. |
This issue is marked as stale due to inactivity. Add a new comment to reactivate it. |
Valid |
If we plan to use Also with the new option, I think we would need another helm flag to specify tls secret name which user would need to pre-create in the controller namespace. |
This issue is marked as stale due to inactivity. Add a new comment to reactivate it. |
This issue is closed due to inactivity. Feel free to reopen it, if it's still relevant. |
valid |
The validating webhook component gets its TLS cert and private key from the
kanister-webhook-certs
secret. These self-signed cert and key aren't always suitable for production environment, where users have their own PKI infrastructure set up.The goal of this issue is to add an new Helm option to:
caBundle
option of theblueprints.cr.kanister.io
validating webhook configurationWhen
webhook.tls.mode
is set tocustom
,webhook.caBundle
must be provided. Otherwise, installation should fail.When
webhook.tls.mode
is unspecified, it should be set toauto
, reverting back to the current behaviour.Documentation follow-up in #1516.
Reference: #1345 (comment)
The text was updated successfully, but these errors were encountered: