Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license #6

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Add license #6

merged 3 commits into from
Mar 27, 2024

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Mar 25, 2024

Adding license.

closes #5

@denisvmedia
Copy link

@mlavi JFYI

@mlavi
Copy link

mlavi commented Mar 25, 2024

We need to add our copyright on Line 190, I'll comment there now.

Copy link

@mlavi mlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update line 190

LICENSE Outdated
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to: Copyright 2024 Kasten, Inc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@e-sumin e-sumin requested a review from mlavi March 26, 2024 10:34
LICENSE Outdated
@@ -187,7 +187,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copyright Copyright 2024 Kasten, Inc.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2x Copyright.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! Fixed.

Copy link

@mlavi mlavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-sumin e-sumin merged commit 88d56fb into main Mar 27, 2024
4 checks passed
@e-sumin e-sumin deleted the license branch March 27, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LICENSE is missing
3 participants