Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dataset env var API to upsert style #1015

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

rmn-boiko
Copy link
Contributor

@rmn-boiko rmn-boiko commented Dec 26, 2024

Description

Closes: kamu-data/kamu-node#139

Checklist before requesting a review

@rmn-boiko rmn-boiko self-assigned this Dec 26, 2024
@rmn-boiko rmn-boiko force-pushed the feat/139-dataset-env-vars-upsert-API branch 4 times, most recently from c2f8724 to b12bc49 Compare December 26, 2024 14:49
@rmn-boiko rmn-boiko marked this pull request as ready for review December 26, 2024 14:57
@rmn-boiko rmn-boiko force-pushed the feat/139-dataset-env-vars-upsert-API branch from b12bc49 to 0f003c5 Compare December 26, 2024 15:05
@zaychenko-sergei
Copy link
Contributor

@dmitriy-borzenko Some updates for you too, before we can merge this.

@rmn-boiko rmn-boiko force-pushed the feat/139-dataset-env-vars-upsert-API branch from 81293b7 to 3f90ebe Compare January 2, 2025 14:29
@rmn-boiko rmn-boiko force-pushed the feat/139-dataset-env-vars-upsert-API branch from 3f90ebe to 53dce09 Compare January 8, 2025 15:43
@zaychenko-sergei zaychenko-sergei force-pushed the feat/139-dataset-env-vars-upsert-API branch from 53dce09 to 09f7d5c Compare January 8, 2025 19:39
@zaychenko-sergei zaychenko-sergei merged commit affeca4 into master Jan 8, 2025
6 checks passed
@zaychenko-sergei zaychenko-sergei deleted the feat/139-dataset-env-vars-upsert-API branch January 8, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide upsert-style API for dataset env vars
2 participants