Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix dataset alias with account name #1008

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Prefix dataset alias with account name #1008

merged 5 commits into from
Dec 27, 2024

Conversation

demusdev
Copy link
Contributor

Description

Closes: #891

Checklist before requesting a review

  • Unit and integration tests added
  • Compatibility:
    • Network APIs: ✅
    • Workspace layout and metadata: ✅ - NO EFFECT
    • Configuration: ✅ - NO EFFECT
    • Container images: ✅ - NO EFFECT
  • Observability:
    • Tracing / metrics: ✅ - NO NEED
    • Alerts: ✅ - NO NEED
  • Documentation:
  • Downstream effects:

@demusdev demusdev self-assigned this Dec 23, 2024
@demusdev demusdev force-pushed the bug/datasets-create-empty-alias branch from c22d5b5 to 7740eb8 Compare December 23, 2024 20:03
s373r
s373r requested changes Dec 24, 2024
View reviewed changes
Copy link
Member

@s373r s373r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments and questions

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/e2e/app/cli/repo-tests/src/rest_api/test_gql_query.rs Outdated Show resolved Hide resolved
src/e2e/app/cli/repo-tests/src/rest_api/test_gql_query.rs Outdated Show resolved Hide resolved
src/e2e/app/cli/repo-tests/src/rest_api/test_gql_query.rs Show resolved Hide resolved
src/infra/core/src/repos/dataset_repository_local_fs.rs Show resolved Hide resolved
s373r
s373r requested changes Dec 24, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@demusdev demusdev requested a review from s373r December 24, 2024 17:01
@demusdev demusdev force-pushed the bug/datasets-create-empty-alias branch from fd19449 to b0e556b Compare December 27, 2024 11:21
@demusdev demusdev force-pushed the bug/datasets-create-empty-alias branch from b0e556b to 91402ec Compare December 27, 2024 11:40
@demusdev demusdev requested a review from sergiimk December 27, 2024 13:58
@demusdev demusdev merged commit 1df9088 into master Dec 27, 2024
6 checks passed
@demusdev demusdev deleted the bug/datasets-create-empty-alias branch December 27, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s373r s373r s373r approved these changes

@zaychenko-sergei zaychenko-sergei zaychenko-sergei approved these changes

@rmn-boiko rmn-boiko Awaiting requested review from rmn-boiko

@sergiimk sergiimk Awaiting requested review from sergiimk

Assignees

@demusdev demusdev

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@demusdev @sergiimk @zaychenko-sergei @s373r