feat: do not output cues that started before the segment #1535
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromecast shakaplayer does not de-duplicate cues in HLS.
This fixes it by only outputing cues that start during the segment.
From my understanding (and some testing), the subtitles will not disappear early on segment change in normal playback if they are not duplicated in all segments. The only ill effect I can think of is that the cue will not appear on seek in some cases. But this is not a common use case, so a much less visible impact than duplicated segments.
For example with 8s segments, segment 2 will be from 00:08:00 to 00:16:00
Before:
s-1-f7.vtt
s-2-f7.vtt
After:
s-1-f7.vtt
s-2-f7.vtt