Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force http connection #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't force http connection #28

wants to merge 2 commits into from

Conversation

redSpoutnik
Copy link

Allow to use "http://" or "https://" in kalliope API url.

Fix #27.

Sispheor
Sispheor reviewed Oct 20, 2019
View reviewed changes
Copy link
Member

@Sispheor Sispheor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
No tests? I would suggest to place this part of code in a function that can be then tested.
@LaMonF this one is for you.

@redSpoutnik
Copy link
Author

Thanks @Sispheor, but I don't see where I am supposed to make unit-tests in the code.
Is there any directory for that?

@LaMonF
Copy link
Member

LaMonF commented Jul 17, 2020

This should target dev branch

@LaMonF LaMonF changed the base branch from master to dev July 17, 2020 16:14
@LaMonF LaMonF changed the base branch from dev to master July 17, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sispheor Sispheor Sispheor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use https to reach kalliope API
3 participants
@redSpoutnik @LaMonF @Sispheor