Alternative synchonization of signalInvalidAndRemoveDependentTransact…

…ions Signed-off-by: Fabio Di Fabio <[email protected]>
kaleido-io · Jun 20, 2023 · 0e2a262 · 0e2a262
1 parent df3bf97
commit 0e2a262
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.../hyperledger/besu/ethereum/eth/transactions/sorter/AbstractPendingTransactionsSorter.java b/.../hyperledger/besu/ethereum/eth/transactions/sorter/AbstractPendingTransactionsSorter.java
@@ -543,7 +543,9 @@ public List<Transaction> signalInvalidAndGetDependentTransactions(final Transact
 
   @Override
   public void signalInvalidAndRemoveDependentTransactions(final Transaction transaction) {
-    signalInvalidAndGetDependentTransactions(transaction).forEach(this::removeTransaction);
+    synchronized (lock) {
+      signalInvalidAndGetDependentTransactions(transaction).forEach(this::removeTransaction);
+    }
   }
 
   @Override

diff --git a/...a/org/hyperledger/besu/ethereum/eth/transactions/sorter/PendingTransactionsForSender.java b/...a/org/hyperledger/besu/ethereum/eth/transactions/sorter/PendingTransactionsForSender.java
@@ -113,9 +113,7 @@ public List<PendingTransaction> getPendingTransactions(final long startingNonce)
   }
 
   public Stream<PendingTransaction> streamPendingTransactions() {
-    synchronized (pendingTransactions) {
-      return List.copyOf(pendingTransactions.values()).stream();
-    }
+    return pendingTransactions.values().stream();
   }
 
   public PendingTransaction getPendingTransactionForNonce(final long nonce) {