회원가입 및 로그인 기능 수정 #99
Merged
회원가입 및 로그인 기능 수정 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JYN523
approved these changes
Oct 21, 2024
Comment on lines
30
to
35
| if (!data.isMember) return navigate(data.redirectUrl); | ||
|
|
||
| if (accessToken) { | ||
| const path = data.isSinitto ? RouterPath.SNITTO : RouterPath.GUARD; | ||
| window.location.href = path; | ||
| } |
There was a problem hiding this comment.
페이지 이동을 navigate와 window.location.href로 다르게 사용한 이유가 있을까요?
There was a problem hiding this comment.
router 설정을 잘못한건지, 이유는 모르겠지만 navigate 를 사용하니까 /redirect/~~ 로 이동하더라구요. 근데 다시 하니까 정상적으로 되는것 같습니다..
navigate로 통일하겠습니다!
Diwoni
reviewed
Oct 22, 2024
| @@ -21,5 +21,6 @@ export const getKakaoCallback = async ( | |||
| code, | |||
| }, | |||
| }); | |||
| console.log(response.data); | |||
There was a problem hiding this comment.
여기는 일부러 카카오 로그인 이후에 들어온 데이터 확인하려고 넣으신건가욤?
This was referenced Oct 25, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close