[기능구현] 회원가입 #59
Merged
[기능구현] 회원가입 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diwoni
added
✨ Feature
Closed
3 tasks
Dobbymin
reviewed
Oct 10, 2024
There was a problem hiding this comment.
https://vite.dev/guide/env-and-mode.html
보통 이런식으로 백엔드 주소를 환경변수 .env 파일로 가려놓는편입니다.
src/pages/common/register/index.tsx
Outdated
Comment on lines
33
to
65
| const mutation = useMutation({ | ||
| mutationFn: registerUser, | ||
| onSuccess: (data: SignupApiResponse) => { | ||
| // 207 (이미 이메일이 존재하면 Multi-Status) | ||
| if ('status' in data && data.status === 207) { | ||
| alert(data.detail); | ||
| } else { | ||
| // 200 (성공) -> 토큰 저장 | ||
| console.log(data); | ||
| // 타입가드 | ||
| if ('accessToken' in data) { | ||
| authLocalStorage.set(data.accessToken); | ||
| authLocalStorage.set(data.refreshToken); | ||
| alert('회원가입이 완료되었습니다.'); | ||
| // 유저 타입에 따라 네비게이션 | ||
| if (data.isSinitto === 'true') { | ||
| navigate(RouterPath.ROOT); | ||
| // navigate(RouterPath.SINITTO_HOME); | ||
| } else { | ||
| navigate(RouterPath.ROOT); | ||
| // navigate(RouterPath.GUARD_HOME); | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| onError: (error: AxiosError) => { | ||
| if (error.response && error.response.data) { | ||
| alert('회원가입 중 오류가 발생했습니다.'); | ||
| } else { | ||
| alert('회원가입 중 네트워크 오류가 발생했습니다.'); | ||
| } | ||
| }, | ||
| }); |
There was a problem hiding this comment.
이렇게 한번에 쓰는것 보다 hook 으로 분리해서 사용하는게 더 좋아보입니다!
Comment on lines
+20
to
+23
| export const BASE_URL = 'http://43.201.254.198:8080'; | ||
|
|
||
| export const fetchInstance = initInstance({ | ||
| baseURL: 'https://api.example.com', | ||
| baseURL: 'http://43.201.254.198:8080', |
Comment on lines
+1
to
+24
| type StorageKey = { | ||
| accessToken?: string; | ||
| }; | ||
|
|
||
| const initStorage = <T extends keyof StorageKey>(key: T, storage: Storage) => { | ||
| const storageKey = `${key}`; | ||
|
|
||
| const get = (): StorageKey[T] => { | ||
| const value = storage.getItem(storageKey); | ||
| return value as StorageKey[T]; | ||
| }; | ||
|
|
||
| const set = (value: StorageKey[T]) => { | ||
| if (value == undefined || value == null) { | ||
| return storage.removeItem(storageKey); | ||
| } | ||
| const stringifiedValue = JSON.stringify(value); | ||
| storage.setItem(storageKey, stringifiedValue); | ||
| }; | ||
|
|
||
| return { get, set }; | ||
| }; | ||
|
|
||
| export const authLocalStorage = initStorage('accessToken', localStorage); |
There was a problem hiding this comment.
이 코드는 step2에서 강사님이 사용하신 코드 같은데, 혹시 어떤 기능을 하는지 알 수 있을까요? 제가 이 코드에 대해 잘 이해를 못해서..
There was a problem hiding this comment.
부족하지만, 제가 정리한 내용입니다..!
JYN523
reviewed
Oct 11, 2024
src/shared/hooks/useRegister.ts
Outdated
There was a problem hiding this comment.
useRegister.ts는 회원가입 페이지에서만 쓰이는데, pages/common/register 폴더 안에 /api 또는 /api/hooks를 만들어야할 것 같습니다.
JYN523
approved these changes
Oct 11, 2024
Dobbymin
approved these changes
Oct 11, 2024
This was referenced Oct 12, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
[기능구현] 회원가입
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close