5주차 코드리뷰 피드백 반영

src/app/routes/index.tsx

@@ -16,66 +16,66 @@ import MyPage from '@/pages/siniddo/mypage';
 
 const router = createBrowserRouter([
   {
-    path: RouterPath.root,
+    path: RouterPath.ROOT,
     element: <MainPage />,
   },
   {
-    path: RouterPath.register,
+    path: RouterPath.REGISTER,
     element: <RegisterPage />,
   },
   {
-    path: RouterPath.mypage,
+    path: RouterPath.MYPAGE,
     element: <MyPage />,
   },
   {
-    path: RouterPath.serviceHistory,
+    path: RouterPath.SERVICE_HISTORY,
     element: <ServiceHistoryPage />,
   },
   {
-    path: RouterPath.helloCall,
+    path: RouterPath.HELLO_CALL,
     children: [
       {
         index: true,
         element: <HelloCallListPage />,
       },
       {
-        path: RouterPath.helloCallService,
+        path: RouterPath.HELLO_CALL_SERVICE,
         element: <HelloCallServicePage />,
       },
       {
-        path: RouterPath.helloCallReport,
+        path: RouterPath.HELLO_CALL_REPORT,
         element: <HelloCallReportPage />,
       },
     ],
   },
   {
-    path: RouterPath.seniorRegister,
+    path: RouterPath.SENIOR_REGISTER,
     element: <SeniorRegisterPage />,
   },
   {
-    path: RouterPath.callBackList,
+    path: RouterPath.CALL_BACK_LIST,
     children: [
       {
         index: true,
         element: <CallBackListPage />,
       },
       {
-        path: RouterPath.callBackDetail,
+        path: RouterPath.CALL_BACK_DETAIL,
         children: [
           {
             index: true,
             element: <CallBackDetailPage />,
           },
           {
-            path: RouterPath.callBackGuidLine,
+            path: RouterPath.CALL_BACK_GUID_LINE,
             element: <SiniddoGuideLinePage />,
           },
         ],
       },
     ],
   },
   {
-    path: RouterPath.siniddoReview,
+    path: RouterPath.SINIDDO_REVIEW,
     element: <SiniddoReviewPage />,
   },
 ]);

src/app/routes/path.ts

@@ -1,15 +1,15 @@
 export const RouterPath = {
-  root: '/',
-  login: '/login',
-  register: '/register',
-  mypage: `/mypage`,
-  serviceHistory: `/service-history`,
-  helloCallService: 'service',
-  helloCallReport: 'report',
-  helloCall: `/hello-call`,
-  callBackList: '/call-back',
-  callBackDetail: ':callBackId',
-  callBackGuidLine: ':guideLineId',
-  seniorRegister: `/senior-register`,
-  siniddoReview: `/siniddo-review`,
+  ROOT: '/',
+  LOGIN: '/login',
+  REGISTER: '/register',
+  MYPAGE: `/mypage`,
+  SERVICE_HISTORY: `/service-history`,
+  HELLO_CALL_SERVICE: 'service',
+  HELLO_CALL_REPORT: 'report',
+  HELLO_CALL: `/hello-call`,
+  CALL_BACK_LIST: '/call-back',
+  CALL_BACK_DETAIL: ':callBackId',
+  CALL_BACK_GUID_LINE: ':guideLineId',
+  SENIOR_REGISTER: `/senior-register`,
+  SINIDDO_REVIEW: `/siniddo-review`,
 };

src/pages/siniddo/call-back/detail/components/menu/pre-accept/index.tsx

@@ -2,13 +2,13 @@ import { BasicButton } from '@/shared/components/common/button';
 import styled from '@emotion/styled';
 
 type Props = {
-  handleClcik: () => void;
+  handleClick: () => void;
 };
 
-export const PreAcceptMenu = ({ handleClcik }: Props) => {
+export const PreAcceptMenu = ({ handleClick }: Props) => {
   return (
     <Wrapper>
-      <BasicButton onClick={handleClcik}>전화걸기 및 수락하기</BasicButton>
+      <BasicButton onClick={handleClick}>전화걸기 및 수락하기</BasicButton>
     </Wrapper>
   );
 };

src/shared/components/common/button/index.tsx

@@ -23,9 +23,8 @@ export const BasicButton = styled.button<Props>`
 
   font-size: var(--font-size-md);
   font-weight: 300;
-
-  transition: background-color 0.3s ease;
-  transition: color 0.3s ease;
+  transition: 0.3s ease;
+  transition-property: background-color, color;
 
   &:hover {
     background-color: #e3e8ef;

src/shared/theme/global/index.ts

@@ -38,7 +38,23 @@ export const globalStyle = css`
     font-family: 'Pretendard-Regular';
     src: url('https://fastly.jsdelivr.net/gh/Project-Noonnu/[email protected]/Pretendard-Regular.woff')
       format('woff');
-    font-weight: 400, 700, 900;
+    font-weight: 400;
+    font-style: normal;
+  }
+
+  @font-face {
+    font-family: 'Pretendard-Regular';
+    src: url('https://fastly.jsdelivr.net/gh/Project-Noonnu/[email protected]/Pretendard-Regular.woff')
+      format('woff');
+    font-weight: 700;
+    font-style: normal;
+  }
+
+  @font-face {
+    font-family: 'Pretendard-Regular';
+    src: url('https://fastly.jsdelivr.net/gh/Project-Noonnu/[email protected]/Pretendard-Regular.woff')
+      format('woff');
+    font-weight: 900;
     font-style: normal;
   }