Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] 시니또 콜백 페이지 관련 오류 수정 #157

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

JYN523
Copy link
Collaborator

@JYN523 JYN523 commented Nov 8, 2024

#️⃣ 연관된 이슈

ex) #이슈번호, - #이슈번호

#156

📝 작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요.(이미지 첨부 가능)

  • 콜백 요청 수락 후 취소 시 발생하는 오류 해결
  • 콜백 요청 완료 시 발생하는 오류 해결
  • alret의 오류 메시지 삭제

스크린샷 (선택)

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

⏰ 현재 버그

✏ Git Close

close #이슈번호

close #156

@JYN523 JYN523 added the 😡 Bug Fix 발생한 버그를 수정하는 경우 label Nov 8, 2024
@JYN523 JYN523 requested review from Diwoni and Dobbymin November 8, 2024 03:05
@JYN523 JYN523 self-assigned this Nov 8, 2024
@JYN523 JYN523 linked an issue Nov 8, 2024 that may be closed by this pull request
Copy link
Contributor

@Dobbymin Dobbymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 부탁드려요!

@@ -48,7 +48,7 @@ export const CallbackMenu = ({
isSuccess: isCancelSuccess,
} = useCancelCallback();
if (isCancelSuccess) {
navigate(RouterPath.CALL_BACK_LIST);
navigate(RouterPath.SINITTO + '/' + RouterPath.CALL_BACK_LIST);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 하면 중간에 공백 들어가지 않나요?? 아닌가?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공백 안 들어가더라고요! '/'만 추가됩니다.

},
onError: (error) => {
alert(`콜백 요청 수락 신청 중 오류가 발생했습니다: ${error.message}`);
onSuccess: () => {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onSuccess를 쓰지 않는다면 지워도 되지 않을까요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇네요! 삭제하겠습니다.

@JYN523 JYN523 merged commit 9ceecd4 into Weekly Nov 8, 2024
1 check passed
@Dobbymin Dobbymin deleted the Feat/issue-#156 branch November 8, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😡 Bug Fix 발생한 버그를 수정하는 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] 시니또 콜백 페이지 관련 오류 수정
2 participants