-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA 수정사항 진행 #145
QA 수정사항 진행 #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파일이 엄청 많네용... 고생하셨습니다.
) : isEditingAccount ? ( | ||
<Flex gap={2}> | ||
<Button | ||
w='100px' | ||
h='40px' | ||
fontSize='md' | ||
colorScheme='teal' | ||
fontSize='16px' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chakra에서는 fontSize='md' 가 16px 인것 같더라구요
onSuccess: () => { | ||
authStorage.accessToken.set(undefined); | ||
authStorage.refreshToken.set(undefined); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove 하는게 낫지 않나요?? 저거 그 제가 잘 모른다고 했던 storage 라서 그런건가요?? undefined로 했을때 키가 남아있는지 확인해봐야할것같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
보니까 키도 같이 제거되더라구요! remove 도 좋지만 일단 Util 함수로 만들어둔 걸 사용하는 게 좋다고 생각해서 사용했습니다!
#️⃣ 연관된 이슈
📝 작업 내용
마이페이지 QA 수정 반영
보호자 홈 화면 UI 수정
안부전화 수정 API 삭제
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close