코드리뷰 반영 + 로그아웃 기능 추가 #129
Merged
코드리뷰 반영 + 로그아웃 기능 추가 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diwoni
added
✨ Feature
|
Dobbymin
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
로그아웃을 진행하고 로그아웃되었다는 알람창이 하나 떴으면 좋겠어요. 바로 첫페이지로 돌아가버리네요
Comment on lines
1
to
2
| import { useLogout } from '@/shared/api/hooks/useLogout'; | ||
| import { BasicButton } from '@/shared/components/common'; |
JYN523
approved these changes
Oct 30, 2024
Comment on lines
+6
to
+31
| type GuidelineInfo = { | ||
| id: number; | ||
| type: string; | ||
| title: string; | ||
| content: string; | ||
| }; | ||
|
|
||
| type UseGuidelineInfoProps = { | ||
| guideline: GuidelineInfo; | ||
| seniorId: number; | ||
| editMutation: UseMutationResult<string, Error, ModifyGuidelineRequest>; | ||
| deleteMutation: UseMutationResult<string, Error, number>; | ||
| }; | ||
|
|
||
| type UseGuidelineInfoReturn = { | ||
| isMore: boolean; | ||
| isEditing: boolean; | ||
| guidelineTitle: string; | ||
| guidelineContent: string; | ||
| toggleContent: () => void; | ||
| setIsEditing: (value: boolean) => void; | ||
| setGuidelineTitle: (value: string) => void; | ||
| setGuidelineContent: (value: string) => void; | ||
| editGuideline: () => void; | ||
| deleteGuideline: () => void; | ||
| }; |
There was a problem hiding this comment.
type은 따로 분리하는 것도 괜찮을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
로그아웃 API 연동
회원가입 후 리다이렉트 적용
코드리뷰 반영
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close