-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
전체적인 Router 수정 #112
전체적인 Router 수정 #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 index.ts 파일이나 경로가 깔끔하게 정리되었네요.. 눈 아프셨을 텐데 고생 많으셨습니다!
라우터 부분은 봤을 때 제 부분은 문제 없는 것 같습니다!
src/app/routes/router.tsx
Outdated
], | ||
}, | ||
{ | ||
// TODO: 콜백에 들어가야 할지 가이드라인에 들어가야 할지 잘 모르겠음. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠 제 생각에는 콜백에 들어가는 게 흐름 상 괜찮을 것 같습니다.
queryClient, | ||
AuthProvider, | ||
globalStyle, | ||
} from '@/shared'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분이 수정 안됐었군요..! 훨씬 깔끔한 것 같습니다!
#️⃣ 연관된 이슈
📝 작업 내용
스크린샷 (선택)
💬 리뷰 요구사항(선택)
⏰ 현재 버그
✏ Git Close