전남대BE_박진화_1주차 과제(step3) #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkeugine
requested changes
Jun 29, 2024
Comment on lines
+43
to
+53
| @Test | ||
| void getAllProducts() throws Exception { | ||
| when(productService.getAllProducts()).thenReturn(Collections.singletonList(product)); | ||
|
|
||
| mockMvc.perform(get("/products")) | ||
| .andExpect(status().isOk()) | ||
| .andExpect(content().contentType(MediaType.TEXT_HTML)) | ||
| .andExpect(view().name("products")) | ||
| .andExpect(model().attributeExists("products")) | ||
| .andExpect(model().attribute("products", Collections.singletonList(product))); | ||
| } |
There was a problem hiding this comment.
현재 테스트가 실패하고 있어요!
PR 을 올리기 전에 프로젝트 컴파일이 잘 되는지,
그리고 테스트가 다 통과되는지 한 번 확인해보고 올리면 좋을 것 같아요 :)
| spring.datasource.driverClassName=org.h2.Driver | ||
| spring.datasource.username=sa | ||
| spring.datasource.password= | ||
| spring.datasource.initialization-mode=always |
There was a problem hiding this comment.
해당 옵션은 deprecated 되고, 새로운 방식이 나왔는데 한 번 적용해보면 어떨까요?
왜 deprecated 되었는지도 한 번 알아보면 좋을 것 같아요 :)
There was a problem hiding this comment.
구글링하던 코드 중에 좀 옛날 코드가 있던 것 같습니다. 한 번 찾아보도록할게요!
Comment on lines
+2
to
+15
| spring.datasource.url=jdbc:h2:mem:testdb | ||
| spring.datasource.driverClassName=org.h2.Driver | ||
| spring.datasource.username=sa | ||
| spring.datasource.password= | ||
| spring.datasource.initialization-mode=always | ||
|
|
||
| # SQL scripts locations | ||
| spring.sql.init.mode=always | ||
| spring.sql.init.schema-locations=classpath:schema.sql | ||
| spring.sql.init.data-locations=classpath:data.sql | ||
|
|
||
| # H2 Console settings | ||
| spring.h2.console.enabled=true | ||
| spring.h2.console.path=/h2-console |
There was a problem hiding this comment.
이게 어쩌다가 들어갔는지 저도 잘 기억이 안나네요..! 없애볼게요!
Comment on lines
+23
to
+26
| @BeforeEach | ||
| void setUp() { | ||
| // 데이터 초기화 코드가 필요할 경우 추가 | ||
| } |
There was a problem hiding this comment.
이전에 남겼던 리뷰를 토대로 생각해보자면
- 불필요한 주석
- 사용하지 않는 코드
이 두가지 모두 해당하는 부분인 것 같아요!
과감하게 지워주도록 하죠 :)
Comment on lines
+28
to
+29
| @Test | ||
| void getAllProducts() { |
There was a problem hiding this comment.
@DisplayName 을 활용하여 테스트에 이름을 지어보는건 어떨까요?
There was a problem hiding this comment.
생각치 못한 부분인데 감사합니다! 테스트에 이름을 붙여보겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
시간이 없어서 빠르게 완료했습니다. 잘못된 부분이 있을 수도 있어서 해당 부분 양해 부탁드립니다.