충남대 FE_박건민 2주차 과제제출 #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taehwanno
requested changes
Jul 7, 2024
src/App.tsx
Outdated
| @@ -1,18 +1,27 @@ | |||
| import styled from '@emotion/styled'; | |||
| import { css } from '@emotion/react'; | |||
There was a problem hiding this comment.
과제에서 구현해야할 부분이 꽤 남은 거 같아서 일요일까지 기다렸다가 변경하신 내용을 기반으로 리뷰 드릴게요!
geonbur
force-pushed
the
geonbur
branch
2 times, most recently
from
d8b4bd5 to
2f92828
Compare
taehwanno
requested changes
Jul 9, 2024
|
|
||
| export const AuthProvider: React.FC<{ children: ReactNode }> = ({ children }) => { | ||
| const [isLoggedIn, setIsLoggedIn] = useState<boolean>(!!sessionStorage.getItem('authToken')); | ||
| const [loginId, setLoginId] = useState<string>(sessionStorage.getItem('authToken') || ''); |
There was a problem hiding this comment.
#20 (comment) 코멘트와 동일한 피드백 드려요! 한번 살펴보시고 개선해보시겠어요?
| const handleLogin = (e: React.FormEvent) => { | ||
| e.preventDefault(); | ||
| login(username); | ||
| navigate(-1); |
There was a problem hiding this comment.
첫 진입한 페이지가 로그인 페이지라면 뒤로가기 할 페이지가 없을 수 있는데, 한번 개선해보시겠어요?
| import React from 'react'; | ||
| import { useNavigate } from 'react-router-dom'; | ||
|
|
||
| import { useAuth } from '../context/AuthContext'; |
There was a problem hiding this comment.
절대 경로 설정했다면 일관되게 코드에도 절대경로 써주는게 좋긴 합니다.
| border-radius: 10px; | ||
| cursor: pointer; | ||
|
|
||
| img { |
There was a problem hiding this comment.
26번 라인은 Item으로 렌더링되는 div의 자손 중에 img 태그는 모두 해당 스타일이 적용되는데요, 해당 방향으로 스타일링을 할 수 있긴 하지만 가급적이라면 스타일링이 각 컴포넌트 영역 내에서만 적용될 수 있도록 해주는게 조금 더 스타일링 변화로 인한 UI 개선시 예상 가능한 코드가 됩니다. 예를 들어, 26번 코드는 styled.img처럼 따로 코드를 추출해서 37번 라인 밑에 컴포넌트를 정의 후 활용할 수 있겠죠. Item 컴포넌트 하위의 img 중에 해당 스타일이 적용되지 않았으면 하는 요소가 있을 경우 수정하기 번거로울테니까요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 제출합니다.