충남대 FE_박건민 3주차 과제 #120
Open
충남대 FE_박건민 3주차 과제 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 13, 2024 06:08
taehwanno
requested changes
Jul 15, 2024
| params: filterOption, | ||
| }); | ||
| return data.products; | ||
| }; |
There was a problem hiding this comment.
지금처럼 프로젝트가 작은 단위일 때는 API 호출 코드는 컴포넌트에 선언해도 괜찮긴한데, 조금만 커져도 하나의 API를 여러 컴포넌트에서 소비할 수 있기에 보통은 컴포넌트 안에서 API 호출 코드를 정의하기 보다는 분리해서 관리하는걸 권장하긴 합니다.
| const fetchThemesData = async () => { | ||
| const response = await apiClient.get<{ themes: ThemeData[] }>('/themes'); | ||
| return response.data.themes; | ||
| }; |
There was a problem hiding this comment.
GET /themes API 호출 코드는 아래 2가지를 포함해서 총 3곳에서 중복해서 적용되고 있네요. API 호출 코드는 컴포넌트에서 따로 추출해서 활용한다면 코드 중복을 제거하고 같은 API 호출 코드에서 일관된 타입을 적용할 수 있겠습니다. 해당 API 호출 뿐만 아니라 다른 API 코드도 포함해서 개선해보면 좋을 거 같아요.
src/pages/Theme/index.tsx
Outdated
| isLoading: isThemeLoading, | ||
| isError: isThemeError, | ||
| error, | ||
| } = useQuery(['theme', themeKey], () => fetchThemeDetails(themeKey), { |
There was a problem hiding this comment.
Suggested change
| } = useQuery(['theme', themeKey], () => fetchThemeDetails(themeKey), { | |
| } = useQuery<ThemeData | undefined, AxiosError>(['theme', themeKey], () => fetchThemeDetails(themeKey), { |
useQuery에 직접 타입 제공해주면 34번 라인의 as AxiosError 제거할 수 있을 거 같네요. as를 통한 type assertion은 코드를 개선해야하는 신호로 받아들이시는게 좋습니다. TypeScript 컴파일러에 잘못된 정보를 전달할 수 있으니 꼭 필요한 상황이 아니라면 쓰지 않는게 좋아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 제출합니다.