-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
전남대 FE_김현채 3주차 과제 #118
Open
HyeonChae1104
wants to merge
23
commits into
kakao-tech-campus-2nd-step2:hyeonchae1104
Choose a base branch
from
HyeonChae1104:hyeonchae1104-step1
base: hyeonchae1104
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
전남대 FE_김현채 3주차 과제 #118
HyeonChae1104
wants to merge
23
commits into
kakao-tech-campus-2nd-step2:hyeonchae1104
from
HyeonChae1104:hyeonchae1104-step1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step 1부터 가지고 있던 api 문제는 제가 vercel에서 배포를 잘못해서 나온 오류인 것 같아 다시 시도해봤지만 404 에러가 떠있는 상태입니다..! react-gift-mock-api 레포지토리를 포크하여 vercel에서 불러와 새프로젝트를 만들었는데 이 과정에서 잘못된 점이 있을까요..? 원래 배포한 후 URL을 검색창에 넣으면 정보가 오는지 확인할 수 있다고 들었는데 그 과정이 안되는 것 같습니다ㅜ
2번째 질문은 step1에 머지해주신 후, step2 PR을 보낼 때 사진에서 어떻게 구성해야 Nextstep에서 리뷰 요청을 할 수 있을까요??
step1 ~ step3 기능 구현을 해보았고, step4의 질문에 대한 답변도 해두었습니다! 잘못된 부분이 있다면 피드백 부탁드립니다! 감사합니다