부산대 Android_김현민 2주차 과제 수정 #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeOhHyung
approved these changes
Jul 10, 2024
Comment on lines
36
to
40
| val db = this.writableDatabase | ||
| private fun insertPharData(db: SQLiteDatabase?) { | ||
| val type = "약국" | ||
| val name = "약국" | ||
| val address = "서울 강남구 대치동" | ||
|
|
||
| for (i in 1..30) { | ||
| val name = "$name$i" | ||
| val address = "$address $i" | ||
| db.execSQL("INSERT INTO $TABLE_PLACE ($COLUMN_TYPE, $COLUMN_NAME, $COLUMN_ADDRESS) VALUES ('$type', '$name', '$address');") | ||
| val nameWithIndex = "$name$i" | ||
| val addressWithIndex = "$address $i" | ||
| db?.execSQL("INSERT INTO $TABLE_PLACE ($COLUMN_TYPE, $COLUMN_NAME, $COLUMN_ADDRESS) VALUES ('$type', '$nameWithIndex', '$addressWithIndex');") |
There was a problem hiding this comment.
db가 null 인지 체크를 미리해서, early return 시키거나 null일때는 이 메소드가 호출안되도록 하는게 좋을것 같습니다. 왜냐면, db가 null 일때도 loop를 30회 수행하고 있을것이라 무의미한 연산이 수행될것 같네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어려웠던 점
중점적으로 리뷰해주셨으면 하는 부분
궁금한 점
재제출
KakaoTalk_20240709_175235343.mp4