Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

전남대 Android_이가현_1주차 과제 #31

Open
wants to merge 34 commits into
base: leeghy
Choose a base branch
from

Conversation

leeghy
Copy link

@leeghy leeghy commented Jun 28, 2024

어려웠던 점

  • 데이터를 전달하는 것
  • 전달한 데이터를 뷰에 누적으로 띄우는 것
  • recyclerView

중점적으로 봐줬으면 하는 부분

  • 코드의 가독성(특히 recyclerView를 활용한 코드의 가독성이 좋은 지 봐주셨으면 좋겠습니다!)
  • 깃 커밋 메시지

leeghy added 30 commits June 25, 2024 12:48
@leeghy leeghy closed this Jul 1, 2024
@leeghy leeghy deleted the gh branch July 1, 2024 02:45
@leeghy leeghy restored the gh branch July 1, 2024 05:15
@leeghy leeghy reopened this Jul 1, 2024
@leeghy leeghy changed the base branch from main to leeghy July 1, 2024 05:16
@leeghy leeghy closed this Jul 1, 2024
@leeghy leeghy deleted the gh branch July 1, 2024 06:00
@leeghy leeghy restored the gh branch July 1, 2024 06:00
@leeghy leeghy reopened this Jul 1, 2024
@bigstark bigstark self-requested a review July 1, 2024 15:18
@bigstark
Copy link

bigstark commented Jul 1, 2024

안녕하세요 이가현님! 앞으로 6주동안 함께하게된 멘토 강대규입니다. 만나서 반가워요.
코드는 전반적으로 한번 훑어봤는데, 목요일까지 일정이 있어 금요일에 상세한 리뷰가 가능할 것 같습니다! 이 점 양해부탁드려요.


깃 커밋 메시지

커밋 메시지는 conventional commit 을 참고해보시면 어떨까 싶어요!

Copy link

@bigstark bigstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다! 코드의 가독성은 매우 좋아요. 메소드 정리도 굉장히 잘 되어있구요. 안드로이드 전반에 대한 경험을 쌓으시면 조금 더 좋을 것 같습니다 👍

app/src/main/java/campus/tech/kakao/contacts/AddInfo.kt Outdated Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/contacts/AddInfo.kt Outdated Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/contacts/AddInfo.kt Outdated Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/contacts/AddInfo.kt Outdated Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/contacts/AddInfo.kt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants