Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
강원대 Android_주민철_1주차 과제(1,2단계) 제출 #25
base: joominchul
Are you sure you want to change the base?
강원대 Android_주민철_1주차 과제(1,2단계) 제출 #25
Changes from 50 commits
e57d2d3
eb1bce6
98e5055
8ac5326
8c14ce2
53b6d61
a433b8c
b6ca6dc
5c36af2
439e8bf
a1a780a
7cbdbaf
23f9cd2
1875c09
5f098c6
29e0327
7e92386
538061a
393bb25
85887d7
11d8e7f
71aca7a
6744323
70a22ee
8c815ea
fde6d93
de866a6
485b61d
f780401
6a61f37
9d1325b
2cbba18
5eb63bb
3cb8dfa
f5352e0
55257d1
38604d8
00f28d4
7bf2f1d
6112333
1d930df
a0d1fc0
ce8f675
27e456d
30f8c13
9f528c8
fd1029d
1d0f244
956c975
0f33cb8
9e33dcc
201f87c
54c2d8c
5f00c86
14c9c0a
68c4c2a
ba6053e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"database-name" 으로 db 인스턴스를 생성하셨는데 현재 AddContact 외에 다른 장소에서 이 이름이 서로 다를 경우 어떻게 작동할까요?
이런 상수와 관련된 부분은 한 곳에서 관리하는게 좋아 보입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RadioGroup이 아니라 RadioButton만 사용하셨네요. RadioButton은 RadioGroup과 작성해야 default를 분명히 할 수 있습니다. 이 경우
sex
변수가 null일 케이스도 존재하겠네요.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이러한 "여자", "남자" 로 표현할 수 있는 enum class를 만들어 관리하면 Human Error를 줄일 수 있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러긴 힘들겠지만 모종의 이유로 insert 쿼리가 실행되는데 10초 이상 지연되면 어떻게 될까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SimpleDateFormat이라고 Date Format을 편하게 사용하기 위한 편의 객체가 제공되어있습니다. 이를 활용해보세요~