Introduce kairos.pull_datasources cmdline option to force pulling them #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kairos-io/kairos#3032 Signed-off-by: Dimitris Karakasilis <[email protected]>
Itxaka
approved these changes
Jan 3, 2025
jimmykarily
commented
Jan 3, 2025
packages/static/kairos-overlay-files/files/system/oem/00_datasource.yaml
Show resolved
Hide resolved
I would also prefer it to be in the user config instead but the overlay files don't have access to the user config, do they? The only option would be to move the condition outside this overlay file and implement this whole stage in immucore itself (where user config is available). Is there any other option I'm missing? |
jimmykarily
deleted the
3032_allow_parsing_datasources_using_cmdline_option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kairos-io/kairos#3032
If we merge this, it needs docs.