fix(k9s): use version attribute for builds #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasthep
force-pushed
the
fix_k9s_version_to_properly_build
branch
from
4be879d to
564fb0f
Compare
Build was using tag and version bump wasn't happening. With this change, we revert back to using the version attribute and remove tag as this is not necessary and would require syncing tags and versions. Furthermore, the version now removes all '+' instead of '-'. Signed-off-by: Thomas Thephasdin <[email protected]>
thomasthep
force-pushed
the
fix_k9s_version_to_properly_build
branch
from
564fb0f to
ccd46b4
Compare
Itxaka
approved these changes
Oct 7, 2024
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build was using tag and version bump wasn't happening. With this change, we revert back to using the version attribute and remove tag as this is not necessary and would require syncing tags and versions. Furthermore, the version now removes all '+' instead of '-'.