Fix online status with more than one NIC #1081
Conversation
For systems with more than one unconfigured NIC, this allows the system to see any one interface online as enough to proceed with online status. Fixes kairos-io/kairos#2898 Signed-off-by: Ben Corrado <[email protected]>
There was a problem hiding this comment.
I would drop the --ipv4 in case we got a network with only ipv6 maybe? if that is not specified, it seems that it will use the configuration from the device to know which version to use so it may be better that way.
Also this will fail to pass CI because you need to bump the minor version of the package, so it gets properly build. Just bump the patch version on https://github.com/kairos-io/packages/blob/main/packages/static/kairos-overlay-files/collection.yaml#L4 :)
Signed-off-by: Ben Corrado <[email protected]>
Signed-off-by: Ben Corrado <[email protected]>
|
hey @bencorrado sorry about this, updating the branch made the version go away as we already bumped it in a different Pr. Could you bump the version? Will merge it afterwards |
Signed-off-by: Itxaka <[email protected]>
|
oh nice, I can push it as well :D |
|
Thanks for merging and shepherding me through @Itxaka Did this count for #hacktoberfest? I want a t-shirt! |
|
@bencorrado I just added the tag, if you are subscribed to hacktoberfest, I would hope that it will eventually show up as counting on their app. As for the kairos tshirt you're in, I'm adding you to the list kairos-io/kairos#2924 |
For systems with more than one unconfigured NIC, this allows the system to see any one interface online as enough to proceed with online status. Fixes kairos:#2898