GitHub action docker build #536
Open
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenshih
commented
Dec 27, 2024
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] |
There was a problem hiding this comment.
This runs the test after merging in a PR or a direct push to main by maintainer.
kenshih
commented
Dec 27, 2024
| - 'Dockerfile' | ||
| - '.github/workflows/docker-build.yml' | ||
| pull_request: | ||
| branches: [ main ] |
There was a problem hiding this comment.
This means, this Github Action with run if a pull request is made on main. So you can quickly evaluate whether the PR contains obvious breaking changes.
You can see a history of runs in the “Actions” tab on github. It looks something like this…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration…
A simple Github Action that will run on any PR to confirm the
Dockerfilebuild anddocker runstill work.Also adds a badge like this
when the
mainbranch is passing. That is, it’s running the first docker command described in the README, and checking to see the output of the example/soundscape analysis is as expected.e.g.