#74 Feat: add post delete function #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
코드가 세밀하게 잘 짜여진 것 같군요 |
yumzen
approved these changes
Dec 23, 2024
| return PostConverter.toPostGetResponse(existingPost); | ||
| boolean isLiked = postLikesRepository.findByPostAndUser(existingPost, user).isPresent(); | ||
|
|
||
| Post updatedPost = Post.withLikeStatus(existingPost, isLiked); |
There was a problem hiding this comment.
isLiked를 Post에서 관리하도록 한 이유가 있나여? 조회할 때마다 update가 일어나니까 isLiked값을 바로 컨버터로 전달해서 반환해주는 것도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용