Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnd 4.1.2 fix #85

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Dnd 4.1.2 fix #85

wants to merge 4 commits into from

Conversation

Kapuzenjoe
Copy link

restore skill/save/ability functionality in dnd 4.1.2.
However, some code cleanup is necessary and the damage critical feature does not work. (the function had not worked for me before)
There is currently no separate reminder for tools, only the one via ability. I have therefore commented out the hook for now.
Since I don't use dae, midi or rsr, I only touched on the core functionalities (as well as the midi flag reminder)

For the fix, I've focused on functionality rather than beauty. If I get the chance, I can do a little clean-up here too, if you want.

restore skill/save/ability functionality in dnd 4.1.2. However, some code cleanup is necessary and the damage critical feature does not work.
@Kapuzenjoe
Copy link
Author

@kaelad02
Good day,
in this PR I made a small mistake in the core.js when passing parameters for the reminder.
For the .updateOptions() function the parameter must be config.rolls[0].options and not dialog. You have to adjust this for all hooks in the file, otherwise you won't get any button highlights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant