Bug #90: Make the 'find java' task recognize Homebrew installed jdk on macOS #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jdk on macOS The JDK installed using Homebrew on macOS has an extra 'Homebrew ' string at the end of the 'OpenJDK Runtime Environment' string, before the build number. This was not recognized, and the build task said that it couldn't find Java. Example output from JDK installed via Homebrew om macOS: openjdk version "23.0.1" 2024-10-15 OpenJDK Runtime Environment Homebrew (build 23.0.1) OpenJDK 64-Bit Server VM Homebrew (build 23.0.1, mixed mode, sharing) Other chores (for devX): * Changed hard-coded #!/usr/bin/bash in some of the .sh scripts to #!/usr/bin/env bash, so that they work on systems where bash is not found at /usr/bin/bash (as e.g. on macOS, where it is in /bin/bash) * Set executable bit on the .sh scripts, to be able to run them just like `./test.sh`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #90: Make the 'find java' task recognize Homebrew installed jdk on macOS
The JDK installed using Homebrew on macOS has an extra 'Homebrew ' string at the end of
the 'OpenJDK Runtime Environment' string, before the build number. This was not recognized,
and the build task said that it couldn't find Java.
Example output from JDK installed via Homebrew om macOS:
Other chores (for devX):
work on systems where bash is not found at /usr/bin/bash (as e.g. on macOS, where it is in /bin/bash)
./test.sh