This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Replace extract-text-webpack-plugin with mini-css-extract #265
+68
−74
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| const path = require("path"); | ||
| const webpack = require("webpack"); | ||
| const babel = require("./config/babel"); | ||
|
|
||
| const env = process.env.NODE_ENV || "development"; | ||
| const useCordova = (process.env.USE_CORDOVA || "false") === "true"; | ||
|
|
@@ -10,27 +9,26 @@ const hotReload = process.env.LIVERELOAD === "true" && !isProd; | |
| const out = path.resolve(__dirname, "dist"); | ||
| const exclusions = /node_modules/; | ||
|
|
||
| process.stderr.write(`Building with env = ${env}\n`); | ||
|
|
||
| // plugin management | ||
| const HTML = require("html-webpack-plugin"); | ||
| const Clean = require("clean-webpack-plugin"); | ||
| const MiniCssExtractPlugin = require("mini-css-extract-plugin"); | ||
| const SpriteLoaderPlugin = require("svg-sprite-loader/plugin"); | ||
| const plugins = [ | ||
| ...require("maji/lib/webpack").plugins, | ||
| new HTML({ | ||
| template: "src/index.html", | ||
| useCordova, | ||
| inject: true, | ||
| minify: isProd | ||
| }), | ||
| new Clean(["dist"], { verbose: false, exclude: [".keep"] }), | ||
| new MiniCssExtractPlugin({ | ||
| filename: "[name].[contenthash].css", | ||
| chunkFilename: "[id].[contenthash].css" | ||
| }), | ||
| new SpriteLoaderPlugin() | ||
| ]; | ||
|
|
||
|
|
@@ -115,31 +113,28 @@ module.exports = { | |
| { test: /\.yml$/, loader: "json-loader!yaml-loader" }, | ||
| { | ||
| test: /\.scss$/, | ||
| use: [ | ||
| isProd ? MiniCssExtractPlugin.loader : "style-loader", | ||
|
There was a problem hiding this comment. I noticed the produced CSS is not minified. According to the docs this requires a separate plugin. |
||
| { | ||
| loader: "css-loader", | ||
| options: { | ||
| modules: true, | ||
| localIdentName: "[path][name]__[local]--[hash:base64:5]" | ||
| } | ||
| }, | ||
| postcssLoader, | ||
| "sass-loader" | ||
| ], | ||
| exclude: /shell.scss$/ | ||
| }, | ||
| { | ||
| test: /shell.scss$/, | ||
| use: [ | ||
| isProd ? MiniCssExtractPlugin.loader : "style-loader", | ||
| "css-loader", | ||
| postcssLoader, | ||
| "sass-loader" | ||
| ] | ||
| }, | ||
| { | ||
| test: /\.svg$/, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this approach the shell CSS is no longer in the head.
For Cordova apps this doesn't really matter a ton, but for PWAs it's nice to have this.
Not sure if it's worth sticking with this though, as the primary use case for Maji remains Cordova apps. WDYT?