This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Replace extract-text-webpack-plugin with mini-css-extract #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on html-webpack-plugin to do the heavy lifting for us
pascalw
reviewed
May 10, 2019
| "sass-loader" | ||
| ], | ||
| use: [ | ||
| isProd ? MiniCssExtractPlugin.loader : "style-loader", |
There was a problem hiding this comment.
I noticed the produced CSS is not minified. According to the docs this requires a separate plugin.
|
|
||
| <% for (var css of htmlWebpackPlugin.files.css.filter((file) => file.indexOf("shell") != -1)) { %> | ||
| <style> | ||
| <%= compilation.assets[css.substr(htmlWebpackPlugin.files.publicPath.length)].source() %> |
There was a problem hiding this comment.
With this approach the shell CSS is no longer in the head.
For Cordova apps this doesn't really matter a ton, but for PWAs it's nice to have this.
Not sure if it's worth sticking with this though, as the primary use case for Maji remains Cordova apps. WDYT?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235
In order to review it's advisable to check the output of
yarn build, since mini-css-extract is only used for production builds.