Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaper Ingress file and output service account. #19

Merged
merged 9 commits into from
May 21, 2021
Merged

Conversation

chaitu6022
Copy link
Contributor

What this PR does?

#17

@chaitu6022 chaitu6022 requested a review from bradfordcp April 26, 2021 14:57
Copy link
Member

@bradfordcp bradfordcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for #17 looks good. I defer to @chrislovecnm for the ingress changes.

test/reaper-ingress.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrislovecnm
Copy link
Contributor

@chaitu6022 please merge if this is ready

@bradfordcp bradfordcp merged commit 4385cba into main May 21, 2021
@bradfordcp bradfordcp deleted the GCP_Makefile branch May 21, 2021 16:44
@chaitu6022 chaitu6022 restored the GCP_Makefile branch May 21, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants