Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove list secret rule #1221

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

michael12312
Copy link
Contributor

@michael12312 michael12312 commented Aug 12, 2024

Closes #1122

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@michael12312 michael12312 requested review from a team as code owners August 12, 2024 01:35
@michael12312 michael12312 changed the title remove list secret rule fix: remove list secret rule Aug 12, 2024
Signed-off-by: michael12312 <[email protected]>
@michael12312
Copy link
Contributor Author

hi @AlexsJones

Can you please help to review this PR?

In this PR, i removed the list secrets rules from clusterrole, also all the rules needed are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposed
Development

Successfully merging this pull request may close these issues.

[BUG]: Unnecessary RBAC permissions
1 participant