Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol table for byte bpe #361

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix symbol table for byte bpe #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sherpa-onnx/csrc/symbol-table.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,16 @@ void SymbolTable::Init(std::istream &is) {
}

assert(!sym.empty());
assert(sym2id_.count(sym) == 0);

// for byte bpe, after replacing ▁ with a space, whose ascii is also 0x20,
// there is a conflict between the real byte 0x20 and ▁, so we disable
// the following check.
//
// Note: Only id2sym_ matters as we use it to convert ID to symbols.
if (sym != " ") {
assert(sym2id_.count(sym) == 0);
}

assert(id2sym_.count(id) == 0);

sym2id_.insert({sym, id});
Expand Down
Loading