-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package.json #26
base: master
Are you sure you want to change the base?
Conversation
The change that was made to the package.json file did not seem to resolve the issue. The later part of the range was removed (i.e. "^1.2.0 || ^6.1.0" changed to "^1.2.0") which I think still excludes anything past version 1.2.x of the fontawesome-svg-core file. I'm not an expert, but I think what needs to change is either to allow higher versions of 6 (i.e. 6.2.0 is the latest) "@fortawesome/fontawesome-svg-core": "^1.2.0 || ^6.0.0" or just allow anything greater than 1.2.0: "@fortawesome/fontawesome-svg-core": ">1.2.0" I'm getting this info from here: https://github.com/npm/node-semver#versions |
@jimappleg8 not an expert either :) im checking this now as I believe that you are mostly correct but the "@fortawesome/fontawesome-svg-core": ">1.2.0" part I am unsure about but this may be my misunderstanding. |
@jimappleg8 i just re-checked out the code and installed via Yarn. I have also updated the package.json and lockfile using npm. I also used https://semver.npmjs.com/ to check and the string i have seems okay although i have updated it to be more permissive. (^6.0.0 instead of ^6.1.0) If you install via yarn you will currently get... if you install via NPM you get.,.. This is not good, looking into the fix... |
@jimappleg8 @lapc002 I have had a PR open for a long time now attempting to fix this. I have now published a fork of this repo on NPM https://github.com/ed-wright/gatsby-plugin-fontawesome-css |
Hey @ed-wright I am very sorry. I don't have time anymore to keep maintaining this project. Let me know if you would like me to transfer it to you. Thanks :) |
Yes please, could you also transfer the npm package ownership too |
Hi @ed-wright thank you very much for offering to take control of the project 🙏🏼. I see this error when I try to transfer the github project to you: I already sent to you the invitation to be a maintainer in |
@jzabala sorted sorry about that :) |
hey @ed-wright no idea what is going on hahah. Do you understand this error? In the meantime I added you as a collaborator of the repo. |
Update peer dependencies to solve issue #22 and allow integration with FontAwesome 6