Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ed-wright
Copy link
Collaborator

@ed-wright ed-wright commented Jul 21, 2022

Update peer dependencies to solve issue #22 and allow integration with FontAwesome 6

@jimappleg8
Copy link

The change that was made to the package.json file did not seem to resolve the issue. The later part of the range was removed (i.e. "^1.2.0 || ^6.1.0" changed to "^1.2.0") which I think still excludes anything past version 1.2.x of the fontawesome-svg-core file.

I'm not an expert, but I think what needs to change is either to allow higher versions of 6 (i.e. 6.2.0 is the latest)

"@fortawesome/fontawesome-svg-core": "^1.2.0 || ^6.0.0"

or just allow anything greater than 1.2.0:

"@fortawesome/fontawesome-svg-core": ">1.2.0"

I'm getting this info from here: https://github.com/npm/node-semver#versions

@ed-wright
Copy link
Collaborator Author

@jimappleg8 not an expert either :) im checking this now as I believe that you are mostly correct but the "@fortawesome/fontawesome-svg-core": ">1.2.0" part I am unsure about but this may be my misunderstanding.

@ed-wright
Copy link
Collaborator Author

@jimappleg8 i just re-checked out the code and installed via Yarn. I have also updated the package.json and lockfile using npm.

I also used https://semver.npmjs.com/ to check and the string i have seems okay although i have updated it to be more permissive. (^6.0.0 instead of ^6.1.0)

image

If you install via yarn you will currently get...

image

if you install via NPM you get.,..

image

This is not good, looking into the fix...

@ed-wright
Copy link
Collaborator Author

@jimappleg8 @lapc002 I have had a PR open for a long time now attempting to fix this. I have now published a fork of this repo on NPM

https://github.com/ed-wright/gatsby-plugin-fontawesome-css
https://www.npmjs.com/package/gatsby-plugin-fontawesome-css-2

@jzabala
Copy link
Owner

jzabala commented Oct 8, 2022

Hey @ed-wright I am very sorry. I don't have time anymore to keep maintaining this project. Let me know if you would like me to transfer it to you.

Thanks :)

@ed-wright
Copy link
Collaborator Author

Yes please, could you also transfer the npm package ownership too

@jzabala
Copy link
Owner

jzabala commented Oct 15, 2022

Hi @ed-wright thank you very much for offering to take control of the project 🙏🏼. I see this error when I try to transfer the github project to you:

Screen Shot 2022-10-14 at 8 44 59 PM

I already sent to you the invitation to be a maintainer in npm:

Screen Shot 2022-10-14 at 8 49 40 PM

@ed-wright
Copy link
Collaborator Author

@jzabala sorted sorry about that :)

@jzabala
Copy link
Owner

jzabala commented Nov 8, 2022

hey @ed-wright no idea what is going on hahah. Do you understand this error?
Screenshot 2022-11-08 at 2 23 28 PM

In the meantime I added you as a collaborator of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants