Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add json pointer and level information in context #234

Merged
merged 10 commits into from
Jan 3, 2024
Merged

Conversation

jy95
Copy link
Owner

@jy95 jy95 commented Dec 31, 2023

#223 and #120

@gnidan Like I explained in #223 (reply in thread) , Having a second pair of eyes could help ;) You have the preview (with its playground) on Vercel to see how it works with your contrived example and others as well

image

{
	"$schema": "http://json-schema.org/draft-07/schema",
	"allOf": [
		{
			"oneOf": [
				{
					"type": "object",
					"properties": {
						"foo": {
							"const": "a"
						}
					}
				}
			]
		}
	]
}

I think we can release this part and later a solution for CreateNodes missing id in html case

Copy link

netlify bot commented Dec 31, 2023

Deploy Preview for delicate-torrone-5d35ee ready!

Name Link
🔨 Latest commit 3eb5a92
🔍 Latest deploy log https://app.netlify.com/sites/delicate-torrone-5d35ee/deploys/6595a5e21c7df50008eb642d
😎 Deploy Preview https://deploy-preview-234--delicate-torrone-5d35ee.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codacy-production bot commented Dec 31, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (68bb794) 906 906 100.00%
Head commit (3eb5a92) 941 (+35) 941 (+35) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#234) 42 42 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jy95 jy95 added the enhancement New feature or request label Dec 31, 2023
@gnidan
Copy link
Contributor

gnidan commented Jan 3, 2024

Besides the above suggestion, I'm going to test this tonight by swizzling components in my schema docs repo, to try to get my desired behavior. Your implementation generally looks good to me (about the same as I had, except I got stuck on the allOfs/etc.)

@jy95 jy95 merged commit 152435f into main Jan 3, 2024
15 checks passed
@jy95
Copy link
Owner Author

jy95 commented Jan 3, 2024

@gnidan 1.10 version will be out so you be free to swizzle it ;)

Copy link

github-actions bot commented Jan 3, 2024

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jy95 jy95 deleted the json-refs branch January 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants