-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json pointer and level information in context #234
Conversation
✅ Deploy Preview for delicate-torrone-5d35ee ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
src/theme/JSONSchemaViewer/JSONSchemaElements/SchemaConditional/if-else-then.tsx
Outdated
Show resolved
Hide resolved
Besides the above suggestion, I'm going to test this tonight by swizzling components in my schema docs repo, to try to get my desired behavior. Your implementation generally looks good to me (about the same as I had, except I got stuck on the allOfs/etc.) |
@gnidan 1.10 version will be out so you be free to swizzle it ;) |
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
#223 and #120
@gnidan Like I explained in #223 (reply in thread) , Having a second pair of eyes could help ;) You have the preview (with its playground) on Vercel to see how it works with your contrived example and others as well
I think we can release this part and later a solution for
CreateNodes
missing id in html case