feat(project): add user_id support for DRM, Live and SSAI #653
Conversation
|
Visit the preview URL for this PR (updated for commit 2371cbe): https://ottwebapp--pr653-feat-add-user-id-sup-byvwt26m.web.app (expires Wed, 15 Jan 2025 13:47:59 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
AntonLantukh
force-pushed
the
feat/add-user-id-support-for-manifest
branch
from
d10c709 to
5ab41dc
Compare
| if (hasServerAds && !isDRM) { | ||
| url.href = `${baseUrl}/v2/sites/${siteId}/media/${mediaid}/ssai.${MANIFEST_TYPE.dash === source.type ? 'mpd' : 'm3u8'}`; |
There was a problem hiding this comment.
@AntonLantukh we believe this now replaces external hosted URLs with the SSAI URL. This prevents playback because the SSAI URL yields an error.
There was a problem hiding this comment.
Hey @ChristiaanScheermeijer ! Could you elaborate on this one? I see we use a APP_API_BASE_URL env which should be cdn.
There was a problem hiding this comment.
If I use an externally hosted media file (e.g. https://videdock.com/video.m3u8) in JW dashboard, this shouldn't be replaced with the SSAI manifest.
There was a problem hiding this comment.
I think it makes sense to check the type (mpd | m3u8) and make changes only for this case.
Description
Add user_id support for DRM, Live and SSAI
This PR solves # .
Steps completed:
According to our definition of done, I have completed the following steps: