Feat / Add new languages (nl/fr/de) #651
Conversation
|
Visit the preview URL for this PR (updated for commit a9108de): https://ottwebapp--pr651-feat-new-languages-4wkfde48.web.app (expires Wed, 29 Jan 2025 13:28:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
langemike
force-pushed
the
feat/new-languages
branch
from
a7ea57c to
e99d334
Compare
| "coupon_not_valid": "Gutscheincode ist ungültig", | ||
| "coupon_not_valid_for_offer": "Gutscheincode ist für dieses Angebot nicht gültig", | ||
| "credit_card": "Kreditkarte", | ||
| "credit_card_name": "Kreditkartename", |
There was a problem hiding this comment.
| "credit_card_name": "Kreditkartename", | |
| "credit_card_name": "Kreditkartenname", |
| "card_lock": "Artikel gesperrt", | ||
| "close_modal": "Panel schließen", | ||
| "confirmation_dialog": { | ||
| "close": "Abbrechen", |
There was a problem hiding this comment.
There are som einconsistencies between formal and informal tone (Du vs Sie) - any preferences here?
Personally, would opt for informal.
There was a problem hiding this comment.
Thanks @morrieinmaas! I think using informal tone is fine, wdyt @AntonLantukh? For Dutch, we do use a formal tone, which is more standard (although perhaps not modern and "hip")
There was a problem hiding this comment.
No problem and my pleasure! I'll update the lot of it in the near future. You canm decide which you prefer. Had a brief chat with @AntonLantukh on slack - apparently Netflix and spiegel use the formal one. So i think formal it is.
Will update in one I got some time spare.
|
@ChristiaanScheermeijer @AntonLantukh - changed everything to formal tone in latest commit. I'll have a re-read at some time to make sure everything is gucci. Meanwhile have a great couple of christmas days |
|
Adjusted to the best of my abilities - @AntonLantukh @ChristiaanScheermeijer |
|
@morrieinmaas thanks a lot! |
| "copied_url": "URL copiée", | ||
| "current_episode": "Épisode actuel", | ||
| "current_video": "Vidéo actuelle", | ||
| "episode": "épisode", |
There was a problem hiding this comment.
Should the first letter be capitalized?
| "geo_blocked_description": "Nous nous excusons, mais ce contenu est actuellement indisponible dans votre région.", | ||
| "geo_blocked_title": "Contenu indisponible" | ||
| }, | ||
| "season": "saison", |
There was a problem hiding this comment.
Should the first letter be capitalized?
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "error_description": "Rechargez cette page ou réessayez plus tard.", | |||
There was a problem hiding this comment.
Rafraîchissez cette page ou réessayez plus tard.
| "submit_config_id": "Soumettre", | ||
| "use_the_jwp_dashboard": "Vous n'avez pas de configuration ? Utilisez le tableau de bord JWP pour créer une configuration d'application ou cliquez sur Annuler pour afficher une démo générique.", | ||
| "view_generic_demo": "Afficher une démo générique ?", | ||
| "viewing_config_demo": "Cela vous redirigera vers une application démo générique. Êtes-vous sûr de vouloir continuer ?" |
There was a problem hiding this comment.
Cela vous redirigera vers une application de démo générique. Êtes-vous sûr de vouloir continuer ?
| "co": "Colorado", | ||
| "ct": "Connecticut", | ||
| "de": "Delaware", | ||
| "dc": "District of Columbia", |
| "pending_downgrade": "Diminution en attente", | ||
| "pending_offer_switch": "Sera mis à jour vers \"{{title}}\" après la prochaine date de facturation", | ||
| "price_paid_with": "{{price}} payé avec {{method}}", | ||
| "price_paid_with_card": "Prix payé avec carte", |
There was a problem hiding this comment.
Prix payé par carte, but we should use avec for cash payments. What are the potential methods in the line above?
| "kr": "Corée, République de", | ||
| "kw": "Koweït", | ||
| "kg": "Kirghizistan", | ||
| "la": "République démocratique populaire lao", |
There was a problem hiding this comment.
République démocratique populaire du Laos
| "ni": "Nicaragua", | ||
| "ne": "Niger", | ||
| "ng": "Nigéria", | ||
| "nu": "Niue", |
| "ws": "Samoa", | ||
| "sm": "Saint-Marin", | ||
| "st": "Sao Tomé-et-Principe", | ||
| "sa": "Arabie saoudite", |
| "sz": "Eswatini", | ||
| "se": "Suède", | ||
| "ch": "Suisse", | ||
| "sy": "République arabe syrienne", |
This change adds and activates 3 new languages:
I kept
us_state.jsonin English.These are all translated using ChatGTP.
Tickets: OTT-2756 & OTT-2763