Fix / Accessibility improvements for Hero shelf pagination and LayoutGrid #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3d9ba92): https://ottwebapp--pr647-fix-a11y-improvement-be62ngb8.web.app (expires Wed, 18 Dec 2024 13:59:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
royschut
approved these changes
Nov 18, 2024
AntonLantukh
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issues were discovered by a https://pagespeed.web.dev/ analysis. These changes could most likely give us a 100% accessibility score.
Changes:
aria-colindex/aria-rowindexmust count from 1<li>(causing invalid HTML markup)disabledattribute to the button when the pagination dot is non-clickable (ascendant element hasaria-hidden="true"attribute)The latter caused an error message in Chrome devtools.
tabIndex={-1}did not solve this on the<li>or<button>, so i resorted to adisabledwhich seems appropriate considering the situation.Tickets: OTT-2784 & OTT-2776