Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat / Platform-agonistic broadcast channel #645

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

royschut
Copy link
Collaborator

@royschut royschut commented Nov 15, 2024

Feat / Platform-agonistic broadcast channel

This PR makes the BroadcastChannel, used by CleengService to keep multiple browser tabs in sync, platform-agnostic. This is a browser API, which should not be used from the common package, so it is now moved to the web platform.

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

Copy link

github-actions bot commented Nov 15, 2024

Visit the preview URL for this PR (updated for commit f0c4f74):

https://ottwebapp--pr645-feat-platform-agnost-k9liyvdf.web.app

(expires Sun, 15 Dec 2024 13:39:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

@royschut royschut marked this pull request as ready for review November 15, 2024 13:38
Copy link
Collaborator

@ChristiaanScheermeijer ChristiaanScheermeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@langemike langemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@royschut royschut merged commit 9815a50 into develop Nov 18, 2024
10 checks passed
@royschut royschut deleted the feat/platform-agnostic-broadcast-channel branch November 18, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants