Fix / Translatable shelf titles for hub pages #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLantukh
approved these changes
Nov 14, 2024
ChristiaanScheermeijer
approved these changes
Nov 14, 2024
royschut
approved these changes
Nov 14, 2024
| @@ -75,7 +75,7 @@ const ShelfList = ({ rows }: Props) => { | |||
| const posterAspect = parseAspectRatio(playlist.cardImageAspectRatio || playlist.shelfImageAspectRatio); | |||
| const visibleTilesDelta = parseTilesDelta(posterAspect); | |||
|
|
|||
| const translatedKey = custom?.[`title-${language}`]; | |||
| const translatedKey = custom?.[`title-${language}`] || (playlist?.[`title-${language}`] as string); | |||
There was a problem hiding this comment.
Suggested change
| const translatedKey = custom?.[`title-${language}`] || (playlist?.[`title-${language}`] as string); | |
| const translatedKey = custom?.[`title-${language}`] || (playlist?.[`title-${language}`] as string | undefined); |
There was a problem hiding this comment.
TypeScript already infers that the value could be undefined due to optional chaining (?.).
There was a problem hiding this comment.
You're bypassing that because of the typecast. @langemike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where translated playlist titles didn't show up as translated shelf titles on the hub page.