Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / remove blue link color in hero description #635

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix / remove blue link color in hero description #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-react/src/components/CollapsibleText/__snapshots__/CollapsibleText.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports[`<CollapsibleText> > renders and matches snapshot 1`] = `
style="max-height: 60px;"
>
<span
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
Test...
</span>
Expand Down
8 changes: 0 additions & 8 deletions packages/ui-react/src/components/Footer/Footer.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@
letter-spacing: 0.15px;
text-align: center;
text-shadow: var(--body-text-shadow);

a,
a:visited,
a:active,
a:hover {
color: currentColor;
text-decoration: underline;
}
}

.list {
Expand Down
12 changes: 6 additions & 6 deletions packages/ui-react/src/components/Footer/__snapshots__/Footer.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`<Footer> > renders and matches snapshot 1`] = `
class="_footer_33bf66 _testFixMargin_33bf66"
>
<div
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
Simple
</div>
Expand All @@ -23,12 +23,12 @@ exports[`<Footer> > renders and matches snapshot with two links 1`] = `
class="_list_33bf66"
>
<li
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
Two links
</li>
<li
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
<a
href="https://www.jwplayer.com/"
Expand All @@ -39,7 +39,7 @@ exports[`<Footer> > renders and matches snapshot with two links 1`] = `
</a>
</li>
<li
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
<a
href="https://www.jwplayer.com/"
Expand All @@ -63,12 +63,12 @@ exports[`<Footer> > renders and matches snapshot without links 1`] = `
class="_list_33bf66"
>
<li
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
Text one
</li>
<li
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
Text two
</li>
Expand Down
11 changes: 11 additions & 0 deletions packages/ui-react/src/components/MarkdownComponent/MarkdownComponent.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,20 @@
text-decoration: underline;
}

a:hover {
opacity: 0.8;
}

ul,
ol,
p {
margin: 1.2em 0;
}
}

.inline {
a,
a:visited {
color: currentColor;
}
}
5 changes: 4 additions & 1 deletion packages/ui-react/src/components/MarkdownComponent/MarkdownComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ const MarkdownComponent: React.FC<Props> = ({ markdownString, className, tag = '
return DOMPurify.sanitize(dirtyHTMLString, { ADD_ATTR: ['target'] });
}, [inline, markdownString]);

return React.createElement(tag, { dangerouslySetInnerHTML: { __html: sanitizedHTMLString }, className: classNames(styles.markdown, className) });
return React.createElement(tag, {
dangerouslySetInnerHTML: { __html: sanitizedHTMLString },
className: classNames(styles.markdown, inline && styles.inline, className),
});
};

export default MarkdownComponent;
2 changes: 1 addition & 1 deletion packages/ui-react/src/components/TruncatedText/__snapshots__/TruncatedText.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exports[`<TruncatedText> > renders and matches snapshot 1`] = `
style="max-height: calc(1.5em * 8); -webkit-line-clamp: 8;"
>
<div
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
Test...
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-react/src/components/VideoDetails/__snapshots__/VideoDetails.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports[`<VideoDetails> > renders and matches snapshot 1`] = `
style="max-height: calc(1.5em * 8); -webkit-line-clamp: 8;"
>
<div
class="_markdown_e219e2"
class="_markdown_e219e2 _inline_e219e2"
>
Video description
</div>
Expand Down
Loading