-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Plans prompt after social register #498
Merged
mirovladimitrovski
merged 13 commits into
develop
from
OWA-73-plans-prompt-after-social-register
Apr 15, 2024
Merged
fix: Plans prompt after social register #498
mirovladimitrovski
merged 13 commits into
develop
from
OWA-73-plans-prompt-after-social-register
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirovladimitrovski
requested review from
darkoatanasovski,
AntonLantukh,
kiremitrov123 and
borkopetrovicc
April 15, 2024 09:03
mirovladimitrovski
changed the base branch from
develop
to
OWA-72-social-media-in-signup-screen
April 15, 2024 09:04
Visit the preview URL for this PR (updated for commit 6f453be): https://ottwebapp--pr498-owa-73-plans-prompt-tba68c17.web.app (expires Wed, 15 May 2024 13:14:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
darkoatanasovski
previously approved these changes
Apr 15, 2024
packages/ui-react/src/containers/AccountModal/forms/Registration.tsx
Outdated
Show resolved
Hide resolved
Base automatically changed from
OWA-72-social-media-in-signup-screen
to
develop
April 15, 2024 11:28
mirovladimitrovski
dismissed
darkoatanasovski’s stale review
April 15, 2024 11:28
The base branch was changed.
AntonLantukh
approved these changes
Apr 15, 2024
mirovladimitrovski
deleted the
OWA-73-plans-prompt-after-social-register
branch
April 15, 2024 13:33
AntonLantukh
changed the title
OWA-73: Plans prompt after social register
fix: Plans prompt after social register
Apr 22, 2024
AntonLantukh
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves #OWA-73.
Also SERV-15345
Steps completed:
According to our definition of done, I have completed the following steps: