Fix / header navigation list (accessibility) #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
ChristiaanScheermeijer,
dbudzins,
AntonLantukh,
MelissaDTH and
royschut
AntonLantukh
approved these changes
Apr 11, 2024
|
@langemike could you please resolve the conflicts? |
langemike
force-pushed
the
fix/header-nav-buttons
branch
from
fd2545f to
4a5eac4
Compare
langemike
force-pushed
the
fix/header-nav-buttons
branch
from
4a5eac4 to
dc9614c
Compare
@AntonLantukh done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change wraps header navigation items within a list.
Since I did not want to apply "reset" styles to the
<ul>withinLayout.module.scss, because it belongs in theHeader.module.scss. So I refactored the Header component to make this possible. I have also moved the.headerButtonCSS code toHeader.module.scssto separate the concerns.Original PR: Videodock#173