Refactor / update pr workflow and utils #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLantukh
approved these changes
Mar 13, 2024
ChristiaanScheermeijer
force-pushed
the
refactor/update-pr-workflow-and-utils
branch
from
badaf12 to
ef74c1f
Compare
ChristiaanScheermeijer
merged commit 11a0c55
into
jwplayer:feat/accessibility-and-bug-fixes
8 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed this morning, I've refactored the metadata utils and added a comment to the AWS S3 workflow.
I also performed a
yarn i18nextwhich updated some translations (mostly ordering) and removed some unused translations.