Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework / sprint 3 rs #454

Closed
wants to merge 48 commits into from
Closed

Rework / sprint 3 rs #454

wants to merge 48 commits into from

Conversation

royschut
Copy link
Collaborator

Rework sprint 3 RS

VincentCouzij and others added 30 commits February 22, 2024 15:26
@VincentCouzij @ChristiaanScheermeijer
chore: add pr deployment previews workflows
be07680
@ChristiaanScheermeijer
fix(payment): redirect to wrong media after payment
bb45b52
@VincentCouzij @MelissaDTH @ChristiaanScheermeijer
chore: add version number to footer text
8a81164 
Co-authored-by: Melissa Hart <[email protected]>
@ChristiaanScheermeijer
fix: show error on email field when invalid
ef6392b
@langemike @ChristiaanScheermeijer
fix(project): favicons & preconnect jwapp.com
bf90a73
@ChristiaanScheermeijer
fix: broken checkbox in personal details form
1adaae3
@ChristiaanScheermeijer
fix: hide disabled questions in personal details screen
8e3db3e
@ChristiaanScheermeijer
fix: improve consents required form error
8289ba1
@ChristiaanScheermeijer
fix: show error when delete account fails
92ddd9c
@ChristiaanScheermeijer
fix: hide optional label in season select dropdown
eac1809
@ChristiaanScheermeijer
fix: shelf margin and grid loading state
72f62a7
@VincentCouzij @ChristiaanScheermeijer
chore: add default config and set demo mode on for build (#127)
afa6438
@langemike @ChristiaanScheermeijer
feat: Render favicons dynamically
e9b4f4b 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@royschut @ChristiaanScheermeijer
refactor(payment): improve choose offer flow
b77d8de
@royschut @ChristiaanScheermeijer
fix(user): fix api error message incomplete
fa9d884
@royschut @ChristiaanScheermeijer
refactor(payment): fix broken waiting for payment
54f5360
@royschut @ChristiaanScheermeijer
refactor(payment): fix infinite loop and subscription switch
b2d3f5c
@royschut @ChristiaanScheermeijer
refactor: adjust to updated FormValidationErrors type
afd8336
@royschut @ChristiaanScheermeijer
refactor(tests): fix unit tests
f633d72
@royschut @ChristiaanScheermeijer
refactor(tests): fix unit tests
4cd5d18
@royschut @ChristiaanScheermeijer
refactor(payment): minor fixes
38dfb98
@royschut @ChristiaanScheermeijer
refactor(payment): update variable names
e6aa10a
@royschut @ChristiaanScheermeijer
fix(payment): ui not updating after paypal payment
ecf9000
@royschut @ChristiaanScheermeijer
refactor: add strict util for modal urls from window location
3629a72
@royschut @ChristiaanScheermeijer
feat(a11y): add auto focus to play/pause button of players
72129f9
@langemike @ChristiaanScheermeijer
fix(menu): prevent text to go on two lines in buttons
299643f
@MelissaDTH @ChristiaanScheermeijer
fix(a11y): ensure wcag compliance with 1.5 line-height for texts (#109)
fea00a4
@MelissaDTH @ChristiaanScheermeijer
feat(a11y): apply the autocomplete attribute to input fields(#115)
dde1f2c
@MelissaDTH @ChristiaanScheermeijer
feat(a11y): apply correct aria attributes and improve searchbar (#117)
b0950d6
@langemike @ChristiaanScheermeijer
feat(a11y): video meta data items separated (#116)
5ef9a64 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
langemike and others added 18 commits February 22, 2024 15:30
@langemike @ChristiaanScheermeijer
fix(a11y): only set focus programmatically on keyboard navigation
bc6e790 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@langemike @ChristiaanScheermeijer
feat(a11y): form validation improvements for screen readers
64d776a 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@MelissaDTH @ChristiaanScheermeijer
fix(a11y): apply aria-hidden to checkbox asterisk (#121)
31ee843
@langemike @ChristiaanScheermeijer
feat(a11y): slide chevron buttons hitarea increased
9c0b13a 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@langemike @ChristiaanScheermeijer
fix(a11y): usermenu item count & correct html structure
804fb6b 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@MelissaDTH @ChristiaanScheermeijer
fix(a11y): roles and aria-attributes regarding modals (#125)
86be194
@langemike @ChristiaanScheermeijer
feat(a11y): slider navigation optimized
c05943b
@ChristiaanScheermeijer
chore: fix react warning
87cdf3d
@MelissaDTH @ChristiaanScheermeijer
fix(payment): layout of invoices on mobile
465cb7c
@langemike @ChristiaanScheermeijer
fix(a11y): optimize footer for accessibility
72dfbbc
@MelissaDTH @ChristiaanScheermeijer
feat(a11y): improve accessibility of sidebar
91fa978
@langemike @ChristiaanScheermeijer
feat(a11y): optimize profile menu
9ade1e9
@MelissaDTH
fix(a11y): improve screenreader focus on start watching button
610f73d
@langemike
fix(a11y): videoplayer focus (iOS) & restoration
f2df2e8 
Co-authored-by: Mike van Veenhuijzen <[email protected]>
@MelissaDTH @ChristiaanScheermeijer
fix: active state of language menu and apply aria-current
46c3eea
@MelissaDTH
fix(search): prevent keyboard from persisting in searchbar on submit
ad92378
@MelissaDTH
fix(a11y): ensure correct focus on first sidebar menu item
f38ab26
@royschut
fix(payment): fix new subscription not showing in UI
f369540
@royschut royschut closed this Feb 28, 2024
@royschut royschut deleted the rework/sprint-3-rs branch February 28, 2024 10:02
@royschut royschut restored the rework/sprint-3-rs branch February 28, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonLantukh AntonLantukh Awaiting requested review from AntonLantukh AntonLantukh will be requested when the pull request is marked ready for review AntonLantukh is a code owner

@dbudzins dbudzins Awaiting requested review from dbudzins dbudzins will be requested when the pull request is marked ready for review dbudzins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@royschut @VincentCouzij @ChristiaanScheermeijer @langemike @MelissaDTH