Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed reference to acts_as_versioned_plugin.sqlite3.db file. #3

Merged
merged 1 commit into from
Apr 18, 2014

Conversation

mjsommer
Copy link

No description provided.

jwhitehorn added a commit that referenced this pull request Apr 18, 2014
Removed reference to acts_as_versioned_plugin.sqlite3.db file.
@jwhitehorn jwhitehorn merged commit 94c7ed8 into jwhitehorn:master Apr 18, 2014
@mjsommer
Copy link
Author

Thanks Jason! Fyi, I am using this with Rails 4 and Postges 9.

As a second request, could we give it a unique name, so I can drop the HTTP reference in my gemfile? Perhaps, acts_as_versioned_jw?

That would clean things up, and make it more official.

Martin

Sent from my 4G phone.

http://www.linkedin.com/in/martinsommer

Jason Whitehorn [email protected] wrote:

Merged #3.


Reply to this email directly or view it on GitHub:
#3

@jwhitehorn
Copy link
Owner

I am more than happy to do that.

Give me until this evening, as work today is going to be rather busy. But, deploying it to rubygems as it's own gem shouldn't be a problem.

@mjsommer
Copy link
Author

Thank you! The acts_as_versioned approach to individual version tables, and retained column names, is much more useful in a SQL environment, than PaperTrail's approach. It good to see it still working in Rails/ActiveRecord 4.

Martin

Sent from my 4G phone.

http://www.linkedin.com/in/martinsommer

Jason Whitehorn [email protected] wrote:

I am more than happy to do that.

Give me until this evening, as work today is going to be rather busy.
But, deploying it to rubygems as it's own gem shouldn't be a problem.


Reply to this email directly or view it on GitHub:
#3 (comment)

@mjsommer
Copy link
Author

Just sent you a second pull request, to fix the index name length issue. Please try to include it. :)

@jwhitehorn
Copy link
Owner

I've merged in pull request #4 and published the gem as acts_as_versioned_jw to rubygems.org.

I appreciate all your help.

@mjsommer
Copy link
Author

Excellent! Thank you.

Martin

Martin

Sent from my 4G phone.

http://www.linkedin.com/in/martinsommer

Jason Whitehorn [email protected] wrote:

I've merged in pull request #4 and published the gem as
acts_as_versioned_jw to rubygems.org.

I appreciate all your help.


Reply to this email directly or view it on GitHub:
#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants