Create pydas package to better organize modules and improve installation process #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're wrapping multiple DAE solvers, it makes sense to collect them into a package. At the same time, we can improve the naming convention by calling the moved modules pydas.dassl and pydas.daspk instead of pydas and pydaspk. This will force everyone to update their import statements.
Also fix a reference to header file das.h (now named pydas/dassl.h) in the pydas.dassl module.
To further tidy up the top project folder.
Similar changes will be required by all end users.
The .pxd files are needed to allow others to link against the compiled pydas.dassl and pydas.daspk modules. The .pyx files are nice to have so that folks have another means of viewing the code behind the compiled modules. Closes #11.
Usage should mirror numpy.get_include(), and thereby make it easier to link against the compiled PyDAS modules.
3 tasks
This is so that users don't have to define their functions or call them with the dummy senpar variable. Keeping the dummy senpar as an optional argument in the initialize function is sufficient.
rwest
added a commit
to ReactionMechanismGenerator/PyDAS
that referenced
this pull request
Mar 12, 2015
This moves files into new pydas package, and means that software
using this library will need to be modified slightly:
-from pydas import DASSL
+from pydas.dassl import DASSL
It also removes DASPK2 and adds DASPK3.1, which allows
sensitivity analysis.
See
jwallen/PyDAS#11
jwallen/PyDAS#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
pydasandpydaspkmodules into a commonpydaspackage, as discussed in #11. As a result of these changes, end users will need to update their import statements, e.g.become
The installers should now include the
.pxdand.pyxfiles in the installed package, so that people can link to the compiled PyDAS modules. There is also apydas.get_include()function that should work like the one from numpy.The test modules were also moved into a
testsfolder.